Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the experimental prefix and rename theme.json files #33925

Merged
merged 4 commits into from
Aug 6, 2021
Merged

Remove the experimental prefix and rename theme.json files #33925

merged 4 commits into from
Aug 6, 2021

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Aug 6, 2021 •
edited
Loading

This PR renames:

  • experimental-default-theme.json to theme.json
  • experimental-i18n-theme.json to theme-i18n.json

so it follows WordPress core names (see).

@oandregal oandregal self-assigned this Aug 6, 2021
@oandregal oandregal added Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Code Quality Issues or PRs that relate to code quality labels Aug 6, 2021
@oandregal oandregal mentioned this pull request Aug 6, 2021
Merged
@oandregal oandregal requested a review from Mamaduka August 6, 2021 10:55
Mamaduka
Mamaduka approved these changes Aug 6, 2021
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick follow-up, @nosolosw.

@oandregal oandregal merged commit 10f2ec1 into trunk Aug 6, 2021
@oandregal oandregal deleted the rename/theme-json-files branch August 6, 2021 12:30
@github-actions github-actions bot added this to the Gutenberg 11.3 milestone Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

Assignees

@oandregal oandregal

Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 11.3
Development

Successfully merging this pull request may close these issues.
2 participants
@oandregal @Mamaduka