Mobile Release v1.59.0 #33913
Merged
Mobile Release v1.59.0 #33913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhnstn
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
5 tasks
dcalhoun
reviewed
Aug 6, 2021
| @@ -667,7 +667,7 @@ | |||
| "CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer"; | |||
| COPY_PHASE_STRIP = NO; | |||
| ENABLE_STRICT_OBJC_MSGSEND = YES; | |||
| "EXCLUDED_ARCHS[sdk=iphonesimulator*]" = "arm64 "; | |||
| "EXCLUDED_ARCHS[sdk=iphonesimulator*]" = ""; | |||
There was a problem hiding this comment.
This seems like an odd change. Based upon e980666, it would appear this was performed by the release script. Any ideas as to why this occurred?
Given its a part of the Demo app and references simulators, I would imagine it would have no negative impact on the release build.
dcalhoun
approved these changes
Aug 6, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release 1.59.0 of the react-native-editor and Gutenberg-Mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#3805
Checklist:
*.native.jsfiles for terms that need renaming or removal).