Fix block appender position in classic themes #33895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
|
Size Change: +3 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Aug 5, 2021
kevin940726
reviewed
Aug 5, 2021
There was a problem hiding this comment.
While this fixes the issue, but I think the semantic could be improved.
As a developer, I would expect wp-block class to be only applied to blocks, but not appenders. That would result in unexpected behaviors if third-party plugin developers decide to use that class. Maybe they should be relying on other ways to select blocks, but better to keep it unambiguous.
Would an alternative like making the necessary styles also apply to block-list-appender work?
|
Unfortunately, we can't change the class at the moment, it's a public API used by themes to define the widths. (See https://developer.wordpress.org/block-editor/how-to-guides/themes/theme-support/#changing-the-width-of-the-editor ) |
|
I mean to change whatever style contribute to fixing the position of the appender to target the |
|
For what it's worth, the control now has two nested instances of the
I think I recall an issue in one of the Twenty themes that was caused by this duplicate class. But I've no strong opinion, and one could argue it's just a nested component, like a block inside a group. |
|
@kevin940726 yes, that's not possible because the style is provided by the themes using the @jasmussen the inner one seems useless indeed. |
7 tasks
|
Created #35356 as a followup to the duplicate wp-block class. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/WordPress/gutenberg/pull/33024/files#r659586330 the
wp-blockclass has been removed from the block appender. I think this was an error, that class is used to define the max-width for blocks which the appender should adhere too, otherwise it will be position on the extreme left.I'm not really sure why the class was removed there.
Testing instructions