Skip to content

Parser: applyBlockValidation revalidating original block instead of fixed #62176

Closed
@tjcafferkey

Description

When initially parsing and loading blocks we attempt to validate their parsed attributes and apply auto-fixes when invalid, before attempting to validate again after the fixes have been applied. This is done after we get a new raw block back after a round of fix attempts, which we can revalidate.

However, looking at this section of code it appears as though we are revalidating the original unvalidatedBlock instead of fixedBlock during the second execution of validateBlock().

It looks to me like on the second run of validateBlock(), we should be passing fixedBlock as the first param instead.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

[Feature] Block APIAPI that allows to express the block paradigm.[Status] In ProgressTracking issues with work in progress[Type] BugAn existing feature does not function as intended

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions