Accessibility - fix narrator in hamburger template #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 17, 2017 20:42
…on a null e.Parameters, but then calls ToString on the result of Deserialize(null) which is also null. A recent change removed the parameter from the navigate in Shell.xaml
Hamburger button was announced as "Hamburger Button button" Hamburger menu item buttons all had the same automation name: "Hamburger Menu Item button" Possible improvement: HamburgerButtonInfo could default its AutomationProperties.Name to that of the first TextBlock that it finds in its content. Then it would not be necessary to set that field on the Info in most cases.
|
I was expecting to see only one commit in this pull request. |
angrah
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.