Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Conversion: Manual Entry Total Calculation #3061

Merged

Conversation

rajadain
Copy link
Member

Overview

Without this, in some cases the "Save" button was not activated even when the shown units matched. Now we always compare the displayed units, ensuring the two are in sync.

Connects #3059

Demo

image

Testing Instructions

  • Stay on release/1.24.0 and bundle
  • Open Firefox and go to :8000/
  • Log in. Ensure your unit scheme is US Customary
  • Search for "Cocalico Creek-Conestoga River" which is a HUC-12 Subwatershed.
  • Make a MapShed project, make a new scenario, and edit the Land Cover
  • Edit Wetlands to be 70 acres, Open Lands to be 126.6 acres
  • Ensure total adds up, but "Save" button is disabled
  • Check out this branch and bundle
  • Hard refresh the page, edit the Land Cover again
  • Edit Wetlands to be 70 acres, Open Lands to be 126.6 acres
  • Ensure total adds up, and "Save" button is enabled
  • Save the edits

Without this, in some cases the "Save" button was not activated
even when the shown units matched.
@rajadain rajadain added bug NSF Funding Source: National Science Foundation Unit Conversion labels Dec 17, 2018
@rajadain rajadain requested a review from mmcfarland December 17, 2018 21:41
@mmcfarland mmcfarland assigned rajadain and unassigned mmcfarland Dec 17, 2018
@rajadain rajadain merged commit 49f5f2f into release/1.24.0 Dec 17, 2018
@rajadain rajadain deleted the tt/unit-conversion-manual-entry-total-calculation branch December 17, 2018 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug NSF Funding Source: National Science Foundation Unit Conversion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants