1.19.3 Support #40
Merged
1.19.3 Support #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50ap5ud5
requested changes
Jan 3, 2023
There was a problem hiding this comment.
Thank you very much for this. This is looking great. I've tested this locally, looks like most things are working well.
There are just some things to change relating to imports.
I'm looking into the Creative Tab issue in Forge too.
Don't worry too much about the dependencies for now, some of the optional ones such as Structure Expansion are mostly there to save us some time when testing things in the development environment.
...c/main/java/whocraft/tardis_refined/common/blockentity/console/GlobalConsoleBlockEntity.java
Outdated
Show resolved
Hide resolved
common/src/main/java/whocraft/tardis_refined/common/tardis/control/ControlSpecification.java
Outdated
Show resolved
Hide resolved
common/src/main/java/whocraft/tardis_refined/common/tardis/themes/ConsoleTheme.java
Outdated
Show resolved
Hide resolved
50ap5ud5
requested changes
Jan 3, 2023
forge/src/main/java/whocraft/tardis_refined/registry/forge/ItemRegistryImpl.java
Show resolved
Hide resolved
forge/src/main/java/whocraft/tardis_refined/registry/forge/ItemRegistryImpl.java
Outdated
Show resolved
Hide resolved
Comment on lines
26
to
28
| public static final ArrayList<Item> CREATIVE_ITEMS = new ArrayList<>(); | ||
| // Forge can't use registry suppliers during startup | ||
| public static final ArrayList<RegistrySupplier<?>> FORGE_CREATIVE_ITEMS = new ArrayList<>(); |
There was a problem hiding this comment.
This workaround looks a bit messy, but not sure if this is affected by a possible limitation of RegistrySupplier. @Suff99 any thoughts on this?
fabric/src/main/java/whocraft/tardis_refined/registry/fabric/DeferredRegistryImpl.java
Show resolved
Hide resolved
Jeryn99
requested changes
Jan 3, 2023
common/src/main/java/whocraft/tardis_refined/client/screen/selections/ShellSelectionScreen.java
Show resolved
Hide resolved
fabric/src/main/java/whocraft/tardis_refined/registry/fabric/DeferredRegistryImpl.java
Show resolved
Hide resolved
forge/src/main/java/whocraft/tardis_refined/common/data/ProviderLootTable.java
Show resolved
Hide resolved
forge/src/main/java/whocraft/tardis_refined/common/data/ProviderLootTable.java
Show resolved
Hide resolved
…ring CreativeModeTabEvent.Register
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What works:
Everything Fabric
DataGen
Almost everything Forge
What doesn't work:
Forge creative tab, debugging still.
I did not bump some deps that were not updated yet, but I set all deps as modCompileOnly so that the mod could be compiled