-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QOL: Making use of Forgix #384
QOL: Making use of Forgix #384
Conversation
looks cool and sounds good |
I would need to see some evidence that forgix is actually stable and handles everything as it should, there was a attempt at this when forgix was created but it always ended up with errors |
Forgix has changed quite a bit since it first released. Works in all the projects i've developed in the past and tested when i implemented it here. |
Although I understand its functionality and mechanism, I am uncertain whether it is essential. We already incorporate the mod loader within the file name and display name on the platforms, rendering a combined jar redundant. Furthermore, will this function seamlessly with UnifiedPublishing or the Jar-in-Jar approach we employ for Fabric? |
I don't quite get what you mean by UnifiedPublishing. If it's referring to uploading to Modrinth/Curseforge then that works fine as they allow you to select multiple mod-loader tags and so apps like Curseforge and prism will work fine with installing the mod. And yes, this PR is not essential to improving the functionality of the mod. But the user experience when manually installing, not everyone looks at the mod loader tags surprisingly. |
I would consider merging this if you can validate that it functions correctly with unified publishing. For more information, please refer to the following link: https://github.com/shedaniel/unified-publishing |
https://github.com/shedaniel/unified-publishing/blob/193c95ef3a5edbe7f336d1f05fed4973e0bf36be/src/main/java/me/shedaniel/unifiedpublishing/CurseforgePublishingTarget.java#L75 These lines show it is a feature to add multiple mod-loaders to a single release. If you approve I can test by creating a Curseforge project, uploading a release then deleting after the test? |
Actually i think i see what you mean. UnifiedPublishing interacts with the task directly? I'll do some personal tests and get back on the results. |
Solved. In the past it wouldn't work as UnifiedPublishing required the tasks to be given directly. However you can now give it a file. So you instead dependsOn the mergeJars before the publishing. Will be pushing the updated build.gradle soon |
Cool, I will merge this - please PR this to the other 1.20 branch aswell |
I merged this and it worked great! Until used with any mod that depended on Tardis Refined |
It is commendable that Architectury is being utilized, allowing compatibility with multiple mod loaders. However, this approach may lead to confusion among less technically adept players. Providing a single jar file for distribution would alleviate any potential misunderstandings. While this solution may not directly enhance the mod's functionality, it would significantly simplify the installation process.