Immersive Portals - Client crash fix #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_portals # Conflicts: # common/src/main/java/whocraft/tardis_refined/compat/portals/BOTIPortalEntity.java
50ap5ud5
requested changes
May 24, 2024
| @@ -127,6 +127,14 @@ public boolean canCraftInDimensions(int width, int height) { | |||
|
|
|||
| @Override | |||
| public ItemStack getResultItem(RegistryAccess registryAccess) { | |||
| if(result.type() instanceof ManipulatorItemResult manipulatorItemResult){ | |||
| return manipulatorItemResult.recipeOutput(); | |||
There was a problem hiding this comment.
Why is this needed? I thought this only get used in vanilla crafting benches.
There was a problem hiding this comment.
You're correct, but if for some weird reason a mod tries to render our recipes out, its better to render something than nothing
| @@ -79,4 +104,11 @@ public void setTardisId(UUID tardisId) { | |||
| this.getEntityData().set(TARDIS_ID, Optional.of(tardisId)); | |||
| } | |||
|
|
|||
| public boolean isValid() { | |||
There was a problem hiding this comment.
Javadocs for what this does would be nice.
50ap5ud5
reviewed
May 24, 2024
| @@ -351,16 +355,29 @@ public static void destroyPortals(TardisLevelOperator operator) { | |||
| if (portalEntry == null) { | |||
| return; | |||
| } | |||
|
|
|||
| PortalManipulation.removeConnectedPortals(portalEntry.getInternalPortal(), portal -> { | |||
|
|
|||
There was a problem hiding this comment.
Is this meant to be left empty?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a issue where the game tries to attach a renderer to a entity that doesn't exist