New Ore and additional changes #199
Conversation
...whocraft/tardis_refined/client/model/blockentity/shell/internal/door/RootShellDoorModel.java
Show resolved
Hide resolved
common/src/main/java/whocraft/tardis_refined/client/renderer/RenderHelper.java
Show resolved
Hide resolved
| public class AstralManipulatorRenderer implements BlockEntityRenderer<AstralManipulatorBlockEntity>, BlockEntityRendererProvider<AstralManipulatorBlockEntity> { | ||
|
|
||
| public AstralManipulatorRenderer(Context context) { | ||
| } |
There was a problem hiding this comment.
Not a big concern, but it's always good to store the context as a field incase we ever do want to use it
But not worth changing at the moment
| @@ -12,8 +16,14 @@ public RootShellDoorBlockEntity(BlockPos blockPos, BlockState blockState) { | |||
| super(BlockEntityRegistry.ROOT_SHELL_DOOR.get(), blockPos, blockState); | |||
| } | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
If it does nothing, do not have it here
If you are removing vanilla functionality, leave a comment
There was a problem hiding this comment.
Comment left.
| import java.util.Arrays; | ||
| import java.util.List; | ||
|
|
||
| // Before 50 says anything. Yes, this should be made into a codec. Will I do it? No. |
There was a problem hiding this comment.
Just let me know what fields are needed lmao
|
|
||
| public enum ScrewdriverMode { | ||
|
|
||
| GENERIC, |
There was a problem hiding this comment.
What is the difference between them all? Javadoc the enum
There was a problem hiding this comment.
Added documentation
|
|
||
|
|
||
|
|
||
| if (useOnContext.getLevel().getBlockState(useOnContext.getClickedPos()).getBlock() == Blocks.IRON_BLOCK) { |
There was a problem hiding this comment.
getLevel is used numerous times, make it a variable
There was a problem hiding this comment.
Made both a variable
|
|
||
| if (useOnContext.getLevel().getBlockState(useOnContext.getClickedPos()).getBlock() == Blocks.IRON_BLOCK) { | ||
| useOnContext.getLevel().setBlockAndUpdate(useOnContext.getClickedPos(), BlockRegistry.ZEITON_FUSED_IRON_BLOCK.get().defaultBlockState()); | ||
| useOnContext.getItemInHand().shrink(1); |
There was a problem hiding this comment.
getItemInHand is used numerous times, make it a variable
Version 1 of the new ore.
Fixes rendering issue on internal root doors.
Updates NBT of the cage generated
...