Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Blog page #479

Merged
merged 5 commits into from
Jul 20, 2023
Merged

Updating Blog page #479

merged 5 commits into from
Jul 20, 2023

Conversation

s2sharpit
Copy link
Member

@s2sharpit s2sharpit commented Jul 11, 2023 •
edited
Loading

Related Issue

  • Information about the related issue

Closes: #305

Describe the changes you've made

Updating Blog Page.

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update.
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original Updated
original screenshot updated screenshot

Code of Conduct

@vercel
Copy link

vercel bot commented Jul 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webxdao-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2023 3:43am

@s2sharpit
removing unnecessary code
d2c2c64 
Signed-off-by: Tushar Saini <s2sharpit@gmail.com>
@s2sharpit
Copy link
Member Author

s2sharpit commented Jul 11, 2023 •
edited
Loading

Subject: Assistance Needed to Complete Blog Page

Hey @Anmol-Baranwal and @vinzvinci,

I hope this message finds you both well. I wanted to reach out and let you know that I have successfully added as much data as I could for the cards on the blog page. However, there is still some missing information that requires your expert assistance to complete.

I kindly request your help in providing the necessary data to fill in the remaining details for the cards. Your expertise in this matter would be truly invaluable.

I greatly appreciate your support and eagerly await your response. If there are any specific instructions or formatting requirements, please do let me know.

Thank you in advance for your time and assistance. I look forward to hearing from you soon.

Please refer to the provided screenshot for reference:
image

@Anmol-Baranwal
Copy link
Member

Subject: Assistance Needed to Complete Blog Page

Hey @Anmol-Baranwal and @vinzvinci,

I hope this message finds you both well. I wanted to reach out and let you know that I have successfully added as much data as I could for the cards on the blog page. However, there is still some missing information that requires your expert assistance to complete.

I kindly request your help in providing the necessary data to fill in the remaining details for the cards. Your expertise in this matter would be truly invaluable.

I greatly appreciate your support and eagerly await your response. If there are any specific instructions or formatting requirements, please do let me know.

Thank you in advance for your time and assistance. I look forward to hearing from you soon.

Please refer to the provided screenshot for reference: image

I will get back to you after discussing it internally.

@s2sharpit
removing cursor-pointer from blog cards
0a8f6d5 
Signed-off-by: Tushar Saini <s2sharpit@gmail.com>
@mkubdev
Copy link
Contributor

mkubdev commented Jul 11, 2023 •
edited
Loading

Hey, at present, our website's blog is purely static and the development of the blog feature is still in progress.
Thank you a lot for your excellent work in integrating it - you've done an outstanding job since the start! 👍🏻 For the time being, you can cease your efforts on this task as the issue has been resolved. Rest assured, once the blog feature is fully developed, we will definitely incorporate your cards into the implementation. 🚀

Btw, there is merge conflict!

@s2sharpit
Copy link
Member Author

Hey, at present, our website's blog is purely static and the development of the blog feature is still in progress. Thank you a lot for your excellent work in integrating it - you've done an outstanding job since the start! 👍🏻 For the time being, you can cease your efforts on this task as the issue has been resolved. Rest assured, once the blog feature is fully developed, we will definitely incorporate your cards into the implementation. 🚀

Thank you for the update! I'm glad to hear that the development of the blog feature is progressing. I appreciate your kind words about my integration work. It's been a pleasure working on this task, and I'm looking forward to seeing the final implementation. If there's anything else I can assist with in the meantime, please let me know. Thank you again!

@s2sharpit
Copy link
Member Author

Hey @vinzvinci @mkubdev,

I truly appreciate your kind words about the work I've done on integrating the blog feature. Considering the blog feature's ongoing development, I'd like to request the merge of this pull request. We'll make the necessary adjustments when the blog feature is fully developed. Merging it now would be beneficial, as it could potentially save us from dealing with more complex merge conflicts later. Your support and understanding are valued. Let's move forward and get this merged! 🙌🏻🚀

vinzvinci
vinzvinci approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@vinzvinci vinzvinci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We can update them soon!

@vinzvinci vinzvinci requested a review from a team July 20, 2023 03:51
@vinzvinci
Copy link
Member

@Anmol-Baranwal the labels up to you and merge

@Anmol-Baranwal
Copy link
Member

Anmol-Baranwal commented Jul 20, 2023 •
edited
Loading

I am currently travelling, I will merge this till 10 in th evening.

@Anmol-Baranwal the labels up to you and merge

@Anmol-Baranwal Anmol-Baranwal merged commit d5158a2 into WebXDAO:main Jul 20, 2023
@Anmol-Baranwal Anmol-Baranwal added gssoc23 Used for GirlScript Summer of Code 2023 level3 implementing major features or refactoring significant parts of the codebase. labels Jul 20, 2023
@Anmol-Baranwal
Copy link
Member

This could be level 2, but considering the complexity of the page and its responsiveness, I think the labels seem correct.

@s2sharpit s2sharpit deleted the blog-page branch July 20, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinzvinci vinzvinci vinzvinci approved these changes

Assignees
No one assigned
Labels
gssoc23 Used for GirlScript Summer of Code 2023 level3 implementing major features or refactoring significant parts of the codebase.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add Blog Page
4 participants
@s2sharpit @Anmol-Baranwal @mkubdev @vinzvinci