Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding title to every page #478

Merged
merged 2 commits into from
Jul 12, 2023
Merged

adding title to every page #478

merged 2 commits into from
Jul 12, 2023

Conversation

s2sharpit
Copy link
Member

Related Issue

  • Information about the related issue

Closes: #418

Describe the changes you've made

Adding a title to every page and default title will be WebXDAO.

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update.
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original Updated
original screenshot updated screenshot

Code of Conduct

Signed-off-by: Tushar Saini <s2sharpit@gmail.com>
@vercel
Copy link

vercel bot commented Jul 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webxdao-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2023 11:54am

@s2sharpit
Copy link
Member Author

Hey @Anmol-Baranwal @vinzvinci
I would like to know your suggestion on the title of team page.
Is it should be WebX Team - WebXDAO or Team - WebXDAO.

For now, I have added title as WebX Team - WebXDAO.

Screenshot:
image

@vinzvinci
Copy link
Member

Use Team - WebXDAO

@vinzvinci vinzvinci added awaiting review gssoc23 Used for GirlScript Summer of Code 2023 labels Jul 10, 2023
@vinzvinci vinzvinci requested a review from a team July 10, 2023 11:18
Signed-off-by: Tushar Saini <s2sharpit@gmail.com>
@s2sharpit
Copy link
Member Author

Use Team - WebXDAO

I have updated as per your suggestion.

@s2sharpit
Copy link
Member Author

Hey @Anmol-Baranwal
Please review this PR.

Copy link
Member

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

@mkubdev mkubdev merged commit a28661d into WebXDAO:main Jul 12, 2023
@s2sharpit s2sharpit deleted the dynamic-title branch July 12, 2023 08:39
@s2sharpit
Copy link
Member Author

s2sharpit commented Jul 12, 2023

Hey @mkubdev & @vinzvinci
Please add appropriate label for level to this PR 🙏.

@mkubdev mkubdev added level2 enhancement of existing features and removed awaiting review labels Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 Used for GirlScript Summer of Code 2023 level2 enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Projects and Contributors page title is not changing as the page changes
4 participants