Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update design of contributors page #476

Merged
merged 7 commits into from
Jul 9, 2023
Merged

Update design of contributors page #476

merged 7 commits into from
Jul 9, 2023

Conversation

s2sharpit
Copy link
Member

Related Issue

  • Information about the related issue

Closes: #446

Describe the changes you've made

Update contributors page

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update.
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original Updated
image image

Code of Conduct

@vercel
Copy link

vercel bot commented Jul 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webxdao-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2023 3:02am

@s2sharpit s2sharpit changed the title Update contributors page Update design of contributors page Jul 8, 2023
mkubdev
mkubdev approved these changes Jul 8, 2023
View reviewed changes
Copy link
Contributor

@mkubdev mkubdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Everything look good to me, thanks a lot for your contribution @s2sharpit 🙏

vinzvinci
vinzvinci approved these changes Jul 8, 2023
View reviewed changes
Copy link
Member

@vinzvinci vinzvinci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinzvinci vinzvinci requested a review from a team July 8, 2023 11:55
Anmol-Baranwal
Anmol-Baranwal requested changes Jul 8, 2023
View reviewed changes
Copy link
Member

@Anmol-Baranwal Anmol-Baranwal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add another link for the commit history with the GitHub Icon in the lower part. (It will be easy for someone to see the contributions and will remove unnecessary negative space)

For example, the contributions of mkubdev can be found here: Contributions of mkubdev

You just need to use the username that is retrieved.

See the steps:

  1. Use the following URL: https://api.github.com/repos/WebXDAO/WebXDAO.github.io/contributors to retrieve the login value, which represents the username.

  2. Then, construct the link using the format: https://github.com/WebXDAO/WebXDAO.github.io/commits?author=<login_value> to add the commit history link with the corresponding username.

Also, why is Dependabot in the list? I understand that it works hard, but can we exclude bots from the list? 😅

Image
image

@s2sharpit
Copy link
Member Author

Thank you @Anmol-Baranwal for providing the instructions. I will add the commit history link with the GitHub Icon as requested. This will address the issue I was seeking assistance with, which is obtaining the link to the commit history.

Regarding the inclusion of Dependabot in the list, I understand your concern. I will exclude bots from the list to ensure it only displays human contributions.

s2sharpit added 2 commits July 8, 2023 21:46
@s2sharpit
Removing bots from the contributors list.
2a5d343 
Signed-off-by: Tushar Saini <s2sharpit@gmail.com>
@s2sharpit
adding commit history link
14b8bbc 
Signed-off-by: Tushar Saini <s2sharpit@gmail.com>
@s2sharpit
Copy link
Member Author

I have updated the PR.
Please review it @Anmol-Baranwal

Anmol-Baranwal
Anmol-Baranwal requested changes Jul 8, 2023
View reviewed changes
Copy link
Member

@Anmol-Baranwal Anmol-Baranwal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image
image

I don't think that the icon showing commit history is best choice.

Recommended icon
image

Yours is also appropriate, but it was confusing for me when I saw this for the first time. So, I believe that it will definitely be for others as well.

@s2sharpit
What do you think?

@s2sharpit
changing icon for commit history link
55a262c 
Signed-off-by: Tushar Saini <s2sharpit@gmail.com>
@s2sharpit
Copy link
Member Author

Hi @Anmol-Baranwal,

I wanted to let you know that I've implemented your suggestion for the icon displaying commit history, and I believe it looks much better now. Thank you for your valuable input!

image

Anmol-Baranwal
Anmol-Baranwal approved these changes Jul 9, 2023
View reviewed changes
Copy link
Member

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. 🚀 Looks good to me.

@thehashmap thehashmap merged commit 0ab1c21 into WebXDAO:main Jul 9, 2023
@s2sharpit s2sharpit deleted the update-contributors-page branch July 9, 2023 09:40
@s2sharpit
Copy link
Member Author

Hey @vinzvinci @thehashmap @Anmol-Baranwal
Please add appropriate labels to this PR 🙏.

@Anmol-Baranwal Anmol-Baranwal added gssoc23 Used for GirlScript Summer of Code 2023 level2 enhancement of existing features labels Jul 9, 2023
@Anmol-Baranwal
Copy link
Member

@thehashmap
Please add the labels before merging the PR, because it may be neglected. Thanks for notifying us @s2sharpit

@thehashmap
Copy link
Contributor

@thehashmap Please add the labels before merging the PR, because it may be neglected. Thanks for notifying us @s2sharpit

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anmol-Baranwal Anmol-Baranwal Anmol-Baranwal approved these changes

@vinzvinci vinzvinci vinzvinci approved these changes

@mkubdev mkubdev mkubdev approved these changes

Assignees

@s2sharpit s2sharpit

Labels
gssoc23 Used for GirlScript Summer of Code 2023 level2 enhancement of existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Implementing new design of Contribution Page
5 participants
@s2sharpit @Anmol-Baranwal @thehashmap @mkubdev @vinzvinci