Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing placement of hamburger to right #458

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

s2sharpit
Copy link
Member

@s2sharpit s2sharpit commented Jun 27, 2023

Related Issue

  • Information about the related issue

Closes: #399

Describe the changes you've made

changing placement of hamburger to right

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update.
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original Updated
image image

Code of Conduct

@vercel
Copy link

vercel bot commented Jun 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webxdao-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 6:03pm

@s2sharpit
Copy link
Member Author

Hey @vinzvinci @Anmol-Baranwal @thehashmap
Please review this PR.

Copy link
Contributor

@thehashmap thehashmap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as mentioned :)

@vinzvinci vinzvinci added gssoc23 Used for GirlScript Summer of Code 2023 level1 Documentation/Minor bug Fix labels Jun 30, 2023
Copy link
Member

@vinzvinci vinzvinci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinzvinci vinzvinci merged commit 22013da into WebXDAO:main Jun 30, 2023
@s2sharpit s2sharpit deleted the hamburgerPlacement branch July 7, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 Used for GirlScript Summer of Code 2023 level1 Documentation/Minor bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Inconsistent Placement of Hamburger Toggle and Navbar Opening Direction
4 participants