Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug: errors and warnings #452

Merged
merged 1 commit into from
Jun 27, 2023
Merged

fix bug: errors and warnings #452

merged 1 commit into from
Jun 27, 2023

Conversation

harmeetsingh11
Copy link
Contributor

Related Issue

Closes: #431

Files modified

  • app/layout.tsx
  • components/main-nav.tsx

Screenshots

WebXDAO.webm

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update.
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Code of Conduct

@vercel
Copy link

vercel bot commented Jun 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webxdao-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 5:44am

@Anmol-Baranwal Anmol-Baranwal self-requested a review June 26, 2023 08:28
@vinzvinci vinzvinci requested review from a team June 26, 2023 09:23
@vinzvinci vinzvinci requested review from a team June 26, 2023 09:25
Anmol-Baranwal
Anmol-Baranwal approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

If you want to increase the level of contribution, then I would suggest fixing good errors shown from the analysis below:
https://pagespeed.web.dev/analysis/https-webxdao-website-ijyjg0yzg-webxdao-vercel-app/mhh3cq2run?form_factor=desktop

vinzvinci
vinzvinci reviewed Jun 27, 2023
View reviewed changes
Copy link
Member

@vinzvinci vinzvinci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging now!

@vinzvinci vinzvinci merged commit 9f6e830 into WebXDAO:main Jun 27, 2023
@vinzvinci vinzvinci added gssoc23 Used for GirlScript Summer of Code 2023 level1 Documentation/Minor bug Fix labels Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinzvinci vinzvinci vinzvinci approved these changes

@thehashmap thehashmap thehashmap approved these changes

@Anmol-Baranwal Anmol-Baranwal Anmol-Baranwal approved these changes

Assignees
No one assigned
Labels
gssoc23 Used for GirlScript Summer of Code 2023 level1 Documentation/Minor bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: errors and warnings reported on browser's console
4 participants
@harmeetsingh11 @vinzvinci @Anmol-Baranwal @thehashmap