Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using src directory For Improving Code Organization #444

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

s2sharpit
Copy link
Member

Related Issue

  • Information about the related issue

Closes: #392

Describe the changes you've made

Incorporating the feature of Next.js 13, which allows for the addition of an "src" folder, could significantly improve the code organization within our project.

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update.
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original Updated
original screenshot updated screenshot

Code of Conduct

@vercel
Copy link

vercel bot commented Jun 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webxdao-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2023 4:13pm

@s2sharpit
Copy link
Member Author

Hey @darkterminal @vinzvinci @siddhi-244 @mkubdev @Mustafiz04 @Anmol-Baranwal @Panquesito7
I have created the pr again for pr #402
Please check this PR.

Copy link
Member

@vinzvinci vinzvinci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinzvinci vinzvinci requested review from a team June 23, 2023 16:41
@vinzvinci vinzvinci added gssoc23 Used for GirlScript Summer of Code 2023 level3 implementing major features or refactoring significant parts of the codebase. labels Jun 23, 2023
Copy link
Contributor

@thehashmap thehashmap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me

@s2sharpit
Copy link
Member Author

Hey @vinzvinci
I would request you to merge it ASAP, otherwise it will show merging conflicts like this pr #402 .

@vinzvinci vinzvinci merged commit a0582e2 into WebXDAO:main Jun 26, 2023
@vinzvinci
Copy link
Member

All good!

@s2sharpit s2sharpit deleted the srcDir branch June 26, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 Used for GirlScript Summer of Code 2023 level3 implementing major features or refactoring significant parts of the codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] To Use src Directory For Improved Code Organization
4 participants