Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Page Added #440

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Error Page Added #440

merged 3 commits into from
Jun 22, 2023

Conversation

PatilHarshh
Copy link
Contributor

@PatilHarshh PatilHarshh commented Jun 21, 2023

Related Issue

  • Error Page Added

Closes: #269

Describe the changes you've made

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update.
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original Updated
original screenshot updated screenshot

Code of Conduct

@vercel
Copy link

vercel bot commented Jun 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webxdao-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 7:34am

@PatilHarshh
Copy link
Contributor Author

@vinzvinci Please Merge it ...
Learnt some thing new and worked first time in Next js

app/not-found.tsx Outdated Show resolved Hide resolved
@PatilHarshh
Copy link
Contributor Author

done @krishstwt

Copy link
Member

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please make it responsive since it is overflowing at a certain screen size.

Image 1
image

Image 2
image

  1. Please change the hover color from red to something slightly different from the primary color. Maybe adjust the opacity so that a minor change is visible on hovering.

If you need help with the code, just let me know.

app/not-found.tsx Outdated Show resolved Hide resolved
app/not-found.tsx Outdated Show resolved Hide resolved
@PatilHarshh
Copy link
Contributor Author

hey @Anmol-Baranwal I Recently make changes if still not responsive please provide me at which length its failing and button hovering also changed

<div className="font-dark mb-8 mt-8 text-4xl font-bold "style={{ color: 'rgba(65, 26, 255, 1)' }}>Page not found</div>
<div className="font-dark mb-8 mt-8 text-2xl text-gray-400">
<div className=" my-8 text-4xl font-bold"style={{ color: 'rgba(65, 26, 255, 1)' }}>Page not found</div>
<div className=" my-8 text-2xl text-gray-400">
It seems like you wandered off too far! You must return back to our guild!
</div>
<a
Copy link
Member

@Anmol-Baranwal Anmol-Baranwal Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add aria-label="Return to Home" to assist screen readers.

<a
  href="/"
  className="duration-400 inline rounded-lg border border-transparent bg-blue-600 px-6 py-4 text-base font-medium leading-6 text-white shadow-2xl transition-all hover:bg-blue-500 focus:outline-none active:bg-blue-300"
  aria-label="Return to Home"
>
  Return Home
</a>

Copy link
Member

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me. Thanks for the changes.

@PatilHarshh
Copy link
Contributor Author

PatilHarshh commented Jun 22, 2023

@vinzvinci please merge it !!!

@Anmol-Baranwal
Copy link
Member

@Anmol-Baranwal Merging?

Yeah, let vinzvinci review this.

Copy link
Member

@vinzvinci vinzvinci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @WebXDAO/gssoc-mentors add level labels

@vinzvinci vinzvinci added the gssoc23 Used for GirlScript Summer of Code 2023 label Jun 22, 2023
@Anmol-Baranwal
Copy link
Member

LGTM! @WebXDAO/gssoc-mentors add level labels

Since this is an entirely new feature or component, I am assigning it a level3. Feel free to change it if you think otherwise.

@Anmol-Baranwal Anmol-Baranwal added the level3 implementing major features or refactoring significant parts of the codebase. label Jun 22, 2023
@vinzvinci vinzvinci merged commit 034157b into WebXDAO:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 Used for GirlScript Summer of Code 2023 level3 implementing major features or refactoring significant parts of the codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add mascot to 404 error page
4 participants