-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error Page Added #440
Error Page Added #440
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@vinzvinci Please Merge it ... |
done @krishstwt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please make it responsive since it is overflowing at a certain screen size.
- Please change the hover color from red to something slightly different from the primary color. Maybe adjust the opacity so that a minor change is visible on hovering.
If you need help with the code, just let me know.
hey @Anmol-Baranwal I Recently make changes if still not responsive please provide me at which length its failing and button hovering also changed |
<div className="font-dark mb-8 mt-8 text-4xl font-bold "style={{ color: 'rgba(65, 26, 255, 1)' }}>Page not found</div> | ||
<div className="font-dark mb-8 mt-8 text-2xl text-gray-400"> | ||
<div className=" my-8 text-4xl font-bold"style={{ color: 'rgba(65, 26, 255, 1)' }}>Page not found</div> | ||
<div className=" my-8 text-2xl text-gray-400"> | ||
It seems like you wandered off too far! You must return back to our guild! | ||
</div> | ||
<a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add aria-label="Return to Home"
to assist screen readers.
<a
href="/"
className="duration-400 inline rounded-lg border border-transparent bg-blue-600 px-6 py-4 text-base font-medium leading-6 text-white shadow-2xl transition-all hover:bg-blue-500 focus:outline-none active:bg-blue-300"
aria-label="Return to Home"
>
Return Home
</a>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Looks good to me. Thanks for the changes.
@vinzvinci please merge it !!! |
Yeah, let vinzvinci review this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @WebXDAO/gssoc-mentors add level labels
Since this is an entirely new feature or component, I am assigning it a |
Related Issue
Closes: #269
Describe the changes you've made
Type of change
What sort of change have you made:
How Has This Been Tested?
Checklist
Screenshots (if applicable)
Code of Conduct