Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing ESlint Error #309

Merged
merged 1 commit into from
May 22, 2023
Merged

Fixing ESlint Error #309

merged 1 commit into from
May 22, 2023

Conversation

s2sharpit
Copy link
Member

Related Issue

  • Fixed the eslint error which was causing failure of build.

Closes: #308

Describe the changes you've made

Type of change

Bug fix.

What sort of change have you made:
I have fixed the formatting and used next/image where it was not used.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update.
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original Updated
original screenshot updated screenshot

Code of Conduct

Signed-off-by: Tushar Saini <s2sharpit@gmail.com>
@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webxdao-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 11:15am

@darkterminal
Copy link
Member

You fixed the classnames order and used Image component from next/image. Woooah amazing!!! I will check soon, I am in barbershop right now 🤣😁

@vinzvinci vinzvinci requested a review from a team May 22, 2023 11:56
Copy link

@siddhi-244 siddhi-244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👀💻

@siddhi-244 siddhi-244 added in review This PR is in Review gssoc23 Used for GirlScript Summer of Code 2023 labels May 22, 2023
Copy link
Member

@vinzvinci vinzvinci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for fixing this so fast!

@vinzvinci vinzvinci merged commit 1b48dbd into WebXDAO:main May 22, 2023
@vinzvinci vinzvinci added the level3 implementing major features or refactoring significant parts of the codebase. label May 22, 2023
@siddhi-244 siddhi-244 removed the in review This PR is in Review label May 22, 2023
@s2sharpit s2sharpit deleted the eslint branch May 22, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 Used for GirlScript Summer of Code 2023 level3 implementing major features or refactoring significant parts of the codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Error Tailwind CSS classNames order Lint on deploy actions
4 participants