-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy more smart pointers in NetworkStorageManager.cpp #33589
Merged
Merged
+100
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rniwa
added
the
Website Storage
Bugs related to storage APIs, including IndexedDB and localStorage
label
Sep 13, 2024
EWS run on current version of this PR (hash 1a4c7af) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Sep 13, 2024
rniwa
added
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
and removed
merging-blocked
Applied to prevent a change from being merged
labels
Sep 13, 2024
https://bugs.webkit.org/show_bug.cgi?id=279558 Reviewed by Sihui Liu. Deployed more smart pointers in the file as warned by the clang static analyzer. * Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseConnection.h: * Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h: * Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp: (WebKit::NetworkStorageManager::NetworkStorageManager): (WebKit::NetworkStorageManager::protectedProcess const): (WebKit::NetworkStorageManager::close): (WebKit::NetworkStorageManager::stopReceivingMessageFromConnection): (WebKit::NetworkStorageManager::prepareForEviction): (WebKit::NetworkStorageManager::protectedWorkQueue const): (WebKit::NetworkStorageManager::originQuotaManagerParameters): (WebKit::NetworkStorageManager::fetchRegistrableDomainsForPersist): (WebKit::NetworkStorageManager::didFetchRegistrableDomainsForPersist): (WebKit::NetworkStorageManager::persist): (WebKit::NetworkStorageManager::resetStoragePersistedState): (WebKit::NetworkStorageManager::clearStorageForWebPage): (WebKit::NetworkStorageManager::cloneSessionStorageForWebPage): (WebKit::NetworkStorageManager::didIncreaseQuota): (WebKit::NetworkStorageManager::fetchData): (WebKit::NetworkStorageManager::deleteData): (WebKit::NetworkStorageManager::deleteDataModifiedSince): (WebKit::NetworkStorageManager::deleteDataForRegistrableDomains): (WebKit::NetworkStorageManager::moveData): (WebKit::NetworkStorageManager::getOriginDirectory): (WebKit::NetworkStorageManager::suspend): (WebKit::NetworkStorageManager::resume): (WebKit::NetworkStorageManager::handleLowMemoryWarning): (WebKit::NetworkStorageManager::syncLocalStorage): (WebKit::NetworkStorageManager::registerTemporaryBlobFilePaths): (WebKit::NetworkStorageManager::requestSpace): (WebKit::NetworkStorageManager::setOriginQuotaRatioEnabledForTesting): (WebKit::NetworkStorageManager::setStorageSiteValidationEnabled): (WebKit::NetworkStorageManager::addAllowedSitesForConnection): (WebKit::NetworkStorageManager::abortOpenAndUpgradeNeeded): (WebKit::NetworkStorageManager::didFireVersionChangeEvent): (WebKit::NetworkStorageManager::abortTransaction): (WebKit::NetworkStorageManager::commitTransaction): (WebKit::NetworkStorageManager::didFinishHandlingVersionChangeTransaction): (WebKit::NetworkStorageManager::createObjectStore): (WebKit::NetworkStorageManager::deleteObjectStore): (WebKit::NetworkStorageManager::renameObjectStore): (WebKit::NetworkStorageManager::clearObjectStore): (WebKit::NetworkStorageManager::createIndex): (WebKit::NetworkStorageManager::deleteIndex): (WebKit::NetworkStorageManager::renameIndex): (WebKit::NetworkStorageManager::putOrAdd): (WebKit::NetworkStorageManager::getRecord): (WebKit::NetworkStorageManager::getAllRecords): (WebKit::NetworkStorageManager::getCount): (WebKit::NetworkStorageManager::deleteRecord): (WebKit::NetworkStorageManager::openCursor): (WebKit::NetworkStorageManager::iterateCursor): (WebKit::NetworkStorageManager::dispatchTaskToBackgroundFetchManager): (WebKit::NetworkStorageManager::closeServiceWorkerRegistrationFiles): (WebKit::NetworkStorageManager::importServiceWorkerRegistrations): (WebKit::NetworkStorageManager::updateServiceWorkerRegistrations): * Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h: * Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp: (WebKit::OriginStorageManager::protectedQuotaManager): * Source/WebKit/NetworkProcess/storage/OriginStorageManager.h: (WebKit::OriginStorageManager::path const): Deleted. (WebKit::OriginStorageManager::originFileCreationTimestamp const): Deleted. (WebKit::OriginStorageManager::setOriginFileCreationTimestamp): Deleted. (WebKit::OriginStorageManager::includedInBackup const): Deleted. (WebKit::OriginStorageManager::markIncludedInBackup): Deleted. Canonical link: https://commits.webkit.org/283598@main
webkit-commit-queue
force-pushed
the
fix279558b
branch
from
September 13, 2024 05:54
1a4c7af
to
513e79a
Compare
Committed 283598@main (513e79a): https://commits.webkit.org/283598@main Reviewed commits have been landed. Closing PR #33589 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
513e79a
1a4c7af
🧪 wincairo-tests