Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation to start page is broken after login #218

Closed
span opened this issue Mar 23, 2016 · 2 comments · Fixed by #229
Closed

Navigation to start page is broken after login #218

span opened this issue Mar 23, 2016 · 2 comments · Fixed by #229

Comments

@span
Copy link

span commented Mar 23, 2016

After logging in the intro page loads fine. When clicking the logo in the top left corner which loads start.mvc I am not redirected to the Introduction: How to work with WebGoat page nor any other page. I simply get a blank screen in the lesson area. The menu loads fine but the cookies/parameters view is not loading.

This is also the case if navigating to "home" by the top left logo from any lesson.

screen shot 2016-03-23 at 20 36 45
@span span mentioned this issue Mar 23, 2016
Closed
@span
Copy link
Author

span commented Mar 28, 2016

So it seems start.mvc is not really "the start". start.mvc gets sent the navigation link from Hammerhead. Hammerhead looks for the parameter start=true to load the correct link before sending it to start.mvc. Without the link the page will not be initialised properly since Backbone will not know which screen to load.

So: we can either link to /WebGoat/welcome.mvc from the logo, or we can link to /WebGoat/?start=true so that Hammerhead redirects us.

I think welcome.mvc seems like a good place and makes for a cleaner URL.

@nbaars
Copy link
Collaborator

nbaars commented Mar 28, 2016

I agree /welcome.mvc looks like a cleaner solution.

span pushed a commit to span/WebGoat that referenced this issue Mar 31, 2016
Load welcome.mvc instead of start.mvc when navigating home on the log, …
7758947 
…fixes WebGoat#218
@span span mentioned this issue Mar 31, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix broken start/home link on logo span/WebGoat
2 participants
@nbaars @span