Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: XXE lesson 12 patch not reset by 'lesson reset' while it IS reset by leaving/returning to lesson #1176

Closed
davewichers opened this issue Nov 28, 2021 · 0 comments · Fixed by #1195
Closed

Minor: XXE lesson 12 patch not reset by 'lesson reset' while it IS reset by leaving/returning to lesson #1176

davewichers opened this issue Nov 28, 2021 · 0 comments · Fixed by #1195
Assignees
@nbaars
Labels
waiting for release Issue is fix, waiting on new release
Milestone
2023.0

Comments

@davewichers
Copy link

When you are on lesson: http://localhost:8080/WebGoat/start.mvc#lesson/XXE.lesson/12, if you apply the 'patch' by clicking on the button at the bottom, and then you hit 'reset lesson', the patch is still applied (or at least it says it is).

Seems like reset lesson should reset everything, including that.

Conversely, when you apply the patch, and then hit browser reload, the 'patch' goes away, which seems like that shouldn't happen. Same thing happens if you leave the XXE lesson, go to another lesson, and come back. Seems like if the patch was applied it should stay applied until you 'reset' the lesson.
@aolle aolle self-assigned this Dec 17, 2021
nbaars added a commit that referenced this issue Dec 19, 2021
@nbaars
Move enabling security to WebGoat core and add resetting the lessons.
197991e 
We can use it for more lessons and showcase how to apply security directly from the source code.

Resolves: #1176
@nbaars nbaars mentioned this issue Dec 19, 2021
Merged
nbaars added a commit that referenced this issue Dec 20, 2021
@nbaars
Move enabling security to WebGoat core and add resetting the lessons.
7091b45 
We can use it for more lessons and showcase how to apply security directly from the source code.

Resolves: #1176
@nbaars nbaars added the waiting for release Issue is fix, waiting on new release label Dec 20, 2021
@nbaars nbaars added this to the 8.2.3 milestone Dec 20, 2021
@nbaars nbaars reopened this Dec 21, 2021
@aolle aolle assigned nbaars and unassigned aolle Dec 21, 2021
@nbaars nbaars closed this as completed in ac4b06f Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nbaars nbaars

Labels
waiting for release Issue is fix, waiting on new release
Projects
None yet
Milestone
2023.0
Development

Successfully merging a pull request may close this issue.

Move enabling security to WebGoat core and add resetting the lessons. WebGoat/WebGoat
3 participants
@nbaars @davewichers @aolle