Skip to content
This repository has been archived by the owner on Dec 22, 2021. It is now read-only.

Some memarg parameters lack a name, others don't #509

Closed
nemequ opened this issue Jun 21, 2021 · 1 comment · Fixed by #520
Closed

Some memarg parameters lack a name, others don't #509

nemequ opened this issue Jun 21, 2021 · 1 comment · Fixed by #520

Comments

@nemequ
Copy link

nemequ commented Jun 21, 2021

It might be too late for this, but the proposal seems to be inconsistent about whether memarg parameters are named or not. For most instructions it is specified as just memarg, but for the load_lane and store_lane instructions it is m: memarg. Obviously it's not a big deal, but the inconsistency is somewhat perplexing.

FWIW, I'd prefer to just make them all named for consistency with the rest of the proposal, but if not it seems appropriate to make them consistently inconsistent with the rest of the proposal :)

@dtig
Copy link
Member

dtig commented Jun 21, 2021

The overview document is inconsistent about how it uses memarg parameter, a better reference may be the https://github.com/WebAssembly/simd/blob/main/proposals/simd/BinarySIMD.md document for the immediate operands that go into each operation. FWIW, the overview documents work well for iterating over the proposal, but sometimes can be imprecise. The text that gets merged into the main spec is updated in the document/ folder to be consistent with the formal WebAssembly spec. That said, I have no objections to the overview document using named memarg parameters everywhere (PRs welcome!).

ngzhian added a commit to ngzhian/simd that referenced this issue Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants