Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transactions: Use correct geometry when adjusting for gravity #2429

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

transactions: Use correct geometry when adjusting for gravity #2429

wants to merge 1 commit into from

Conversation

soreau
Copy link
Member

@soreau soreau commented Aug 11, 2024

It is apparent from the comment following this line, that this was the intention. This fixes a decoration sizing bug with ignore_views matching 'maximized is true'. This can be seen when toggling maximized for apps such as wcm.

@soreau
transactions: Use correct geometry when adjusting for gravity
9e8aa3d 
It is apparent from the comment following this line, that this was the
intention. This fixes a decoration sizing bug with ignore_views matching
'maximized is true'. This can be seen when toggling maximized for apps
such as wcm.
ammen99
ammen99 approved these changes Sep 7, 2024
View reviewed changes
Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

ammen99
ammen99 requested changes Sep 7, 2024
View reviewed changes
Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, just before I merge this, I figured out that this might not be entirely correct. adjust_geometry_for_gravity changes _pending.geometry to match toplevel_size. Why do you think that this change is needed?

@soreau
Copy link
Member Author

soreau commented Sep 7, 2024

Actually, just before I merge this, I figured out that this might not be entirely correct. adjust_geometry_for_gravity changes _pending.geometry to match toplevel_size. Why do you think that this change is needed?

I have explained in the initial comment. Is it not clear how to reproduce the problem? Do you need further explanation or a video?

@soreau
Copy link
Member Author

soreau commented Sep 7, 2024

Actually, just before I merge this, I figured out that this might not be entirely correct. adjust_geometry_for_gravity changes _pending.geometry to match toplevel_size. Why do you think that this change is needed?

I have explained in the initial comment. Is it not clear how to reproduce the problem? Do you need further explanation or a video?

On second thought, I tested this against latest pixdecor and it does not fix the bug, where the size becomes larger, after toggling maximize with ignore_views = maximized is true. I have to look more into it again.

@soreau soreau marked this pull request as draft September 7, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammen99 ammen99 ammen99 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soreau @ammen99