Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull bug fixes into dev #900

Merged
merged 10 commits into from
Jul 1, 2022
Merged

Pull bug fixes into dev #900

merged 10 commits into from
Jul 1, 2022

Conversation

akeeste
Copy link
Contributor

@akeeste akeeste commented Jun 29, 2022

This PR pulls the following bug fixes and changes to master into the dev branch:

kmruehl and others added 9 commits May 20, 2022 11:16
adding dev and master build status to README
* Update tutorials to fix OSWEC inertia

* Update terminology.rst

* Update tutorials.rst

changed OSWEC Iyy and added note

Co-authored-by: Kelley Ruehl <kmruehl@sandia.gov>
…h | Add 2021b to MATLAB versions (#862)

* Split docs CI into test and build jobs

This PR splits the docs CI workflow into two independent jobs. The
first "test" job checks the current branch with any warnings
triggering a failure. The second jobs builds and deploys the
production docs, allowing any warnings to pass. This allows the
commit author to see any new issues they may be adding to the docs
while not stopping the docs being published.

* Try to get color output in log

* Remove redundant steps for branch test

* Fix duplicate targets using anonymous references

* Cancel previous runs if new commits are made

* Fix spelling mistake to test concurrency

* Limit concurrency to pull requests for the unit tests

This is to ensure all commits on the master and dev branches are
tested, which will be important if we are going to measure
coverage using an external service like codecov.

* Fix another spelling mistake

* Add R2021b to explicit MATLAB versions tested
* Moved simulationClass.outputDir to public.

* Replaced paths with fullfile paths in CompareBEMIO.m. The paths didd not work on Mac due to file separator.

* Update line 38 in reaadAQWA.m so it works on a Mac.

* change filesep in BEMIO examples, update readAQWA fileparts

* Update stopWecSim.m

Replaced hardcoded 'output' string with simu.outputDir.

* Removed clc and close all from initializeWecSim.

It should be up to the user to clear the command windows and close the figures.

Co-authored-by: Lermart96 <anders.brandt@oceanharvesting.com>
Co-authored-by: akeeste <akeeste@sandia.gov>
* Update stopWecSim.m

* Update initializeWecSim.m

* Update wecSimPCT.m
@kmruehl kmruehl mentioned this pull request Jul 1, 2022
@kmruehl kmruehl added the Bug bug in WEC-Sim source, high priority label Jul 1, 2022
@kmruehl
Copy link
Contributor

kmruehl commented Jul 1, 2022

@akeeste please merge this at the end of today's working meeting.

@akeeste akeeste merged commit 860ffbe into dev Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug bug in WEC-Sim source, high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants