Easier to use right click interaction for touchscreens #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or tap/hold/drag/release to select an item
kprinssu
reviewed
Mar 29, 2023
kprinssu
approved these changes
Mar 30, 2023
|
Thanks again for the hard work @lazd! |
|
Well done. Thanks for working on this! |
|
Thanks, @blankmac! If you get a chance to test this, please let me know if you see any strange behavior and I'd be glad to circle back and fix it. I'll be testing extensively on my machine as well. |
|
I'm noticing a couple quirks with this, such as left clicks being triggered before the right click fires, so I'm be working on a fix for that and for scroll behavior sometimes turning into drag if you don't lift both fingers at precisely the same time. If anyone finds other bugs, please let me know! |
|
@lazd Please create a follow up a PR! Thanks again for the effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can tap/hold/release and the menu persists or tap/hold/drag/release to select an item.
A timer is now used instead of ticks to determine if a right click should be triggered, and the delay for triggering has been shortened substantially (now it more closely matches Windows).
A deadzone is introduced after right clicking that ensures the menu does not close due to the cursor moving after the right click has been triggered.
After a right click has been triggered, inputs are considered hovers, not clicks, and a special case has been introduced to simulate a click when lifting the finger for a tap/hold/drag/release interaction. This makes using the menu natural for both tap/hold/release/tap to select item in menu or tap/hold/drag/release to select item in menu interaction patterns.
Right.click.demo.mov