Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aws eks hello world example #399

Merged
merged 7 commits into from
Apr 2, 2024

Conversation

polkx
Copy link
Collaborator

@polkx polkx commented Feb 21, 2024

No description provided.

@polkx polkx requested a review from pawelprazak February 21, 2024 13:59
@polkx polkx self-assigned this Feb 21, 2024
@pawelprazak pawelprazak added the area/examples Usage examples label Feb 21, 2024
@pawelprazak
Copy link
Contributor

@polkx
Copy link
Collaborator Author

polkx commented Feb 22, 2024

Thank you. What is new vs. https://github.com/VirtusLab/besom/blob/main/examples/aws-eks/Main.scala ?

In this example, I added the ability to see running application on a browser.

@pawelprazak
Copy link
Contributor

Could you incorporate this feature into existing example?

@pawelprazak pawelprazak added this to the 0.2.3 milestone Feb 22, 2024
@pawelprazak pawelprazak modified the milestones: 0.2.3, 0.2.4 Feb 28, 2024
@pawelprazak pawelprazak modified the milestones: 0.2.4, 0.3.0 Mar 24, 2024
Copy link
Contributor

@pawelprazak pawelprazak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. I've resolved the conflict in project.scala

@pawelprazak pawelprazak merged commit b67453c into main Apr 2, 2024
1 check passed
@pawelprazak pawelprazak deleted the kpoliwka/aws-eks-hello-world-example branch April 2, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/examples Usage examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants