Introduce a new render_in_view_context test helper to render arbitrary logic in the view #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camertron
changed the title
|
Consensus on the team is to define another method for this, since it's potentially surprising/confusing that the block is evaluated in the view context. Maybe call it |
joelhawksley
reviewed
May 4, 2022
joelhawksley
reviewed
May 4, 2022
Co-authored-by: Joel Hawksley <joel@hawksley.org>
camertron
changed the title
joelhawksley
approved these changes
May 12, 2022
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Dec 22, 2023
…y logic in the view (ViewComponent#1339) * Enable rendering arbitrary block contents in the view context in tests * Add CHANGELOG entry * Fix linting and coverage * Update docs * Update lib/view_component/test_helpers.rb * Update docs/api.md Co-authored-by: Joel Hawksley <joel@hawksley.org> * Move functionality to new render_in_view_context method * Revert autogen docs changes; add yard comment back in * Add missing space Co-authored-by: Joel Hawksley <joel@hawksley.org>
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Jan 3, 2024
…y logic in the view (ViewComponent#1339) * Enable rendering arbitrary block contents in the view context in tests * Add CHANGELOG entry * Fix linting and coverage * Update docs * Update lib/view_component/test_helpers.rb * Update docs/api.md Co-authored-by: Joel Hawksley <joel@hawksley.org> * Move functionality to new render_in_view_context method * Revert autogen docs changes; add yard comment back in * Add missing space Co-authored-by: Joel Hawksley <joel@hawksley.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm currently working on a forms framework at GitHub that uses view components. Forms are rendered like so:
The
render_inlinetest helper works great for individual component instances, but doesn't let me also test the wrappingform_withcall. I propose a modification torender_inlinethat evaluates the block in the view context usinginstance_execso this is possible: