-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relative translation scopes #1335
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camertron
reviewed
Apr 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! 🎉 Could you add a test for the array case? Thanks!
docs/CHANGELOG.md
Outdated
@@ -9,6 +9,10 @@ title: Changelog | |||
|
|||
## main | |||
|
|||
* Add support for relative I18n scopes to translations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
* Add support for relative I18n scopes to translations | |
* Add support for relative I18n scopes to translations. |
elia
force-pushed
the
elia/relative-translation-scopes
branch
from
April 20, 2022 18:45
753b710
to
69b17d5
Compare
elia
force-pushed
the
elia/relative-translation-scopes
branch
from
April 20, 2022 18:47
69b17d5
to
592bae1
Compare
joelhawksley
approved these changes
Apr 20, 2022
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Dec 22, 2023
* Remove unnecessary require * Add support for relative I18n scopes * Update test/view_component/translatable_test.rb * Update lib/view_component/translatable.rb Co-authored-by: Joel Hawksley <joel@hawksley.org>
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Jan 3, 2024
* Remove unnecessary require * Add support for relative I18n scopes * Update test/view_component/translatable_test.rb * Update lib/view_component/translatable.rb Co-authored-by: Joel Hawksley <joel@hawksley.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for relative scopes, i.e. scopes starting with a
.
that will be prefixed to the translation key and then chained to the component base scope.Fixes #1334
Other Information