Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate Jason's docs #1331

Merged
merged 14 commits into from
Apr 14, 2022
Merged

Incorporate Jason's docs #1331

merged 14 commits into from
Apr 14, 2022

Conversation

joelhawksley
Copy link
Member

Summary

This PR attempts to distill @jasonswett's contribution in #1323 down to its very essence, clearly communicating that ViewComponents give view logic the home it deserves ❤️

@joelhawksley joelhawksley requested a review from a team as a code owner April 14, 2022 14:39
@joelhawksley joelhawksley changed the title Jason docs Incorporate Jason's docs Apr 14, 2022
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
Copy link
Member Author

@joelhawksley joelhawksley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asd

@joelhawksley joelhawksley merged commit b2d64fc into main Apr 14, 2022
@joelhawksley joelhawksley deleted the jason-docs branch April 14, 2022 17:56
claudiob pushed a commit to claudiob/view_component that referenced this pull request Dec 22, 2023
* Add "why" explanation to landing page.

* Add self to contributor list, add changelog entry.

* Reconcile old "why" with new "why".

* Change section order on landing page.

* Remove version number heading.

* Fix heading hierarchy.

* condense cohesion docs for landing page

* tighten copy

* fix heading levels, add TLDR

* fix spacing

* Apply suggestions from code review

Co-authored-by: Jason Swett <jason@mhcare.com>
Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com>
claudiob pushed a commit to claudiob/view_component that referenced this pull request Jan 3, 2024
* Add "why" explanation to landing page.

* Add self to contributor list, add changelog entry.

* Reconcile old "why" with new "why".

* Change section order on landing page.

* Remove version number heading.

* Fix heading hierarchy.

* condense cohesion docs for landing page

* tighten copy

* fix heading levels, add TLDR

* fix spacing

* Apply suggestions from code review

Co-authored-by: Jason Swett <jason@mhcare.com>
Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants