-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documented test helper, rendered_component
, renaming
#1375
Comments
@tysongach we do our best to stick to SemVer, but missed this one. The method is marked as private and only snuck into the docs incidentally. I could see us making it public. I'd prefer to push folks towards using the standard What do you think we should do? |
Quoting myself from another thread:
Given that, I'm wondering if we should add a |
That’s okay - it happens 🙂
Ah - thanks for the clarity!
I think you’re spot on about using It feels like there are folks besides just me talking about this rename and it causing issues for them. Given that, I wonder if next steps could be:
|
👋 Hi!
I’m noticing that the
rendered_component
test helper, which is documented in the Testing guide on viewcomponent.org, was renamed suddenly in v2.56.0 (and v2.56.1). That caught me off-guard coming in through a minor (and patch) release update.Does ViewComponent stick to SemVer? Or is
rendered_component
/rendered_content
considered private?The text was updated successfully, but these errors were encountered: