When a task is ready to run and enqueued, mark it as started right away #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves a bug where a task might be enqueued in the executor service for longer than the stale timeout, so the cache believes that the running task is in fact stale/canceled, and attempts to cancel it, but this races against the task actually starting and trying to use the files it expected to have access to. Fixes Vertispan#186
|
To test this, the stale age and update interval can be sped up by setting these in MAVEN_OPTS: |
This means that a jvm shouldn't be able to race itself for staleness, but will only race other JVMs, including ones that have already exited. There is a risk here of one JVM being delayed, or the FS not correctly reflected "last modified time" between two JVMs - we might need a more approriate channel with which to communicate.
treblereel
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves a bug where a task might be enqueued in the executor service
for longer than the stale timeout, so the cache believes that the
running task is in fact stale/canceled, and attempts to cancel it, but
this races against the task actually starting and trying to use the
files it expected to have access to.
Fixes #186