Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly support reading files by path #152

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Correctly support reading files by path #152

merged 1 commit into from
Mar 21, 2022

Conversation

niloc132
Copy link
Member

No description provided.

@niloc132 niloc132 added bug Something isn't working maven labels Mar 21, 2022
@niloc132 niloc132 added this to the 0.20 milestone Mar 21, 2022
@niloc132 niloc132 requested a review from treblereel March 21, 2022 17:28
niloc132
niloc132 commented Mar 21, 2022
View reviewed changes
j2cl-maven-plugin/src/test/java/com/vertispan/j2cl/mojo/Xpp3DomConfigValueProviderTest.java
// exception is expected
}
}
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline

@treblereel treblereel mentioned this pull request Mar 21, 2022
Merged
treblereel
treblereel approved these changes Mar 21, 2022
View reviewed changes
Copy link
Collaborator

@treblereel treblereel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done ! good to go

@niloc132 niloc132 merged commit c2a562d into Vertispan:main Mar 21, 2022
treblereel pushed a commit to treblereel/j2clmavenplugin that referenced this pull request Jun 3, 2022
@niloc132 @treblereel
Correctly support reading files by path (Vertispan#152)
620b565 
This includes a test that turns on enough maven internals to verify we
can resolve and download an artifact. It is fairly hacky though, and
probably could be expressed more simply.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treblereel treblereel treblereel approved these changes

Assignees
No one assigned
Labels
bug Something isn't working maven
Projects
None yet
Milestone
0.20
Development

Successfully merging this pull request may close these issues.
2 participants
@niloc132 @treblereel