Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to_int computation so invalid cases are not used to generate numbers #132

Merged
merged 2 commits into from
Mar 17, 2024

Conversation

jurajsic
Copy link
Member

No description provided.

@jurajsic jurajsic requested a review from vhavlena March 17, 2024 10:02
@jurajsic
Copy link
Member Author

Benchmark stringfuzz/to120.csv
# of formulae: 1608
--------------------------------------------------
tool                          ✅    ❌    avg    med    time    sat    unsat    unknown    TO    MO+ERR    other
--------------------------  ----  ----  -----  -----  ------  -----  -------  ---------  ----  --------  -------
z3-noodler-3da14d1-2cddb2f  1606     2   0.04   0.01   64.01    285     1321          2     0         0        0
z3-noodler-77f7c04-2cddb2f  1606     2   0.06   0.01   94.62    285     1321          2     0         0        0
--------------------------------------------------

Benchmark str_small_rw/to120.csv
# of formulae: 80
--------------------------------------------------
tool                          ✅    ❌    avg    med    time    sat    unsat    unknown    TO    MO+ERR    other
--------------------------  ----  ----  -----  -----  ------  -----  -------  ---------  ----  --------  -------
z3-noodler-3da14d1-2cddb2f    73     7   0.01   0.01    0.81      0       73          1     5         1        0
z3-noodler-77f7c04-2cddb2f    73     7   0.01   0.01    0.74      0       73          1     5         1        0
--------------------------------------------------

[/var/folders/f1/d3j3qhzn3lg8qg7r1x_2vxnm0000gn/T/ipykernel_10459/4044844237.py:37](https://file+.vscode-resource.vscode-cdn.net/var/folders/f1/d3j3qhzn3lg8qg7r1x_2vxnm0000gn/T/ipykernel_10459/4044844237.py:37): DtypeWarning: Columns (1,3,5,7,9,11,13,15,17,19,21,23,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,65,69,71,73,75,79,81,83,85,87,89,91,93,95,97,103,105,107,109,111,113,127,131,145,147,149,151,153,157,169,171,173,175,177,181,183,185,187,189,191,193,195,199,201,203) have mixed types. Specify dtype option on import or set low_memory=False.
Benchmark full_str_int/to120.csv
# of formulae: 16130
--------------------------------------------------
tool                           ✅    ❌    avg    med     time    sat    unsat    unknown    TO    MO+ERR    other
--------------------------  -----  ----  -----  -----  -------  -----  -------  ---------  ----  --------  -------
z3-noodler-3da14d1-2cddb2f  15872   258   0.19   0.01  3049.03   2258    13614        126   132         0        0
z3-noodler-77f7c04-2cddb2f  15862   268   0.25   0.01  3901.78   2249    13613        126   142         0        0
--------------------------------------------------

Copy link
Collaborator

@vhavlena vhavlena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. There is even some (bit unexpected) improvement on full_str_int.

@jurajsic jurajsic merged commit 0751e1e into devel Mar 17, 2024
@jurajsic jurajsic deleted the toint-fix branch March 17, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants