Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-2874] Deploy Oracles to Base Sepolia #235

Merged
merged 8 commits into from
Nov 22, 2024
Merged

[VEN-2874] Deploy Oracles to Base Sepolia #235

merged 8 commits into from
Nov 22, 2024

Conversation

web3rover
Copy link
Contributor

Description

Resolves #

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@web3rover web3rover self-assigned this Nov 8, 2024
@web3rover web3rover requested a review from chechu November 8, 2024 12:32
GitGuru7
GitGuru7 reviewed Nov 14, 2024
View reviewed changes
Copy link
Contributor

@GitGuru7 GitGuru7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to add new network in ci.yml

helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
deployments/basesepolia/BoundValidator_Implementation.json Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
contracts 85% 80% ✔
contracts.interfaces 28% 21% ❌
contracts.oracles 88% 80% ✔
contracts.oracles.common 100% 100% ✔
Summary 83% (288 / 345) 76% (142 / 188) ✔

@chechu chechu merged commit 9a44cd1 into develop Nov 22, 2024
4 checks passed
@chechu chechu mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitGuru7 GitGuru7 GitGuru7 left review comments

@chechu chechu chechu approved these changes

Assignees

@web3rover web3rover

Labels
base sepolia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@web3rover @chechu @GitGuru7