Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: default.csv をリソースディレクトリへ移動 #1244

Merged
merged 3 commits into from
May 17, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented May 14, 2024

内容

default.csv をリソースディレクトリへ移動してリファクタリングすることを提案します。

変更後、以下のチェックをおこないました:

  • pyinstaller ビルド → 成功
  • ./dist/run/run 実行 → 成功
  • AudioQuery へ TALQu を渡して実行 → とーく にパース成功

関連 Issue

step1 of #1243

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです!

あとはビルド後のテスト結果を見ると良さそう。

@tarepan tarepan marked this pull request as ready for review May 17, 2024 20:19
@tarepan tarepan requested a review from a team as a code owner May 17, 2024 20:19
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 17, 2024 20:19
@tarepan
Copy link
Contributor Author

tarepan commented May 17, 2024

@Hiroshiba
全指摘箇所の反映・テストパスを確認しました。Re-review よろしくお願いします。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

自動devリリース&テストが楽しみですね!!

@Hiroshiba Hiroshiba merged commit 931ddec into VOICEVOX:master May 17, 2024
4 checks passed
@tarepan tarepan deleted the refactor/resource_dict_csv branch May 18, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants