Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: ポータル機能を router へ分離 #1221

Merged
merged 5 commits into from
May 17, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented May 10, 2024

内容

ポータル機能を router へ分離してリファクタリング

関連 Issue

無し

@tarepan tarepan requested a review from a team as a code owner May 10, 2024 12:45
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 10, 2024 12:45
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

portalだと何のポータルかわからないから、ファイル名などをportal_pageにしても良いかも?

@tarepan
Copy link
Contributor Author

tarepan commented May 14, 2024

ファイル名などをportal_page

👍️
リネームしました。


@Hiroshiba
全指摘箇所の反映・テストパスを確認しました。Re-review よろしくお願いします。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Hiroshiba Hiroshiba merged commit 81a0a2f into VOICEVOX:master May 17, 2024
4 checks passed
@tarepan tarepan deleted the refactor/portal_router branch May 17, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants