Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

整理: Speaker と内部型の分離 #1202

Merged
merged 10 commits into from
May 6, 2024
Merged

整理: Speaker と内部型の分離 #1202

merged 10 commits into from
May 6, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented May 1, 2024 •
edited
Loading

内容

整理: VV API Speaker 型と ENGINE 内部型（CoreSpeaker・EngineSpeaker）を分離してリファクタリングした。

属性 SpeakerStyle も CoreSpeakerStyle として分離したため、VV API 話者情報と Core 話者情報は完全に分離された。
これによりピッチ範囲情報を任意の箇所（ENGINE or CORE）に実装可能となる。

関連 Issue

ref #1121 (comment)

@tarepan tarepan requested a review from a team as a code owner May 1, 2024 00:20
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 1, 2024 00:20
Hiroshiba
Hiroshiba reviewed May 3, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです！！

きれいな変更ありがとうございます！！！！
ちょっとデータの流れをより健全にできるからと思っていくつかコメントしてみました 🙇

voicevox_engine/metas/Metas.py Outdated Show resolved Hide resolved
voicevox_engine/metas/MetasStore.py Outdated Show resolved Hide resolved
voicevox_engine/metas/MetasStore.py Outdated Show resolved Hide resolved
@tarepan tarepan requested a review from a team as a code owner May 3, 2024 07:18
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 3, 2024 07:18
@tarepan
Copy link
Contributor Author

tarepan commented May 3, 2024

@Hiroshiba
全指摘箇所の反映・テストパスを確認しました。Re-review よろしくお願いします。

Hiroshiba
Hiroshiba approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！！

差分も綺麗だと感じました！

１点ちょっとどっちか迷ったのをコメントしました 🙇

voicevox_engine/metas/MetasStore.py Outdated Show resolved Hide resolved
@tarepan
Copy link
Contributor Author

tarepan commented May 6, 2024

@Hiroshiba
全指摘箇所の反映・テストパスを確認しました。Re2-review よろしくお願いします。

@Hiroshiba Hiroshiba merged commit 440ff07 into VOICEVOX:master May 6, 2024
3 checks passed
@tarepan tarepan deleted the refactor/core_speaker branch May 6, 2024 05:51
@tarepan tarepan mentioned this pull request May 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarepan @Hiroshiba