fix(VKCOM theme): Use vkCom theme color for vkCom gradient instead of base vk theme #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be similar to the content backgroud color
Coverage report
Test suite run success462 tests passing in 37 suites. Report generated by 🧪jest coverage report action from 3ea313a |
qurle
approved these changes
Sep 24, 2024
8coon
approved these changes
Sep 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Заметили, что в теме vkCom цвет градиента темнее чем цвет острова (Group).
Связано это с тем, что в теме vkCom для градиента используется цвет из базовой темы
base/vk.jsОбновил цвет градиента для базовой темы.
Используем сразу цвета из темы
vkcom_dark.Перед отправкой этого реквеста на ревью убедитесь, что:
npm run build:local),npm test),npm run lint), некоторые ошибки можно автоматически поправить с помощьюnpm run lint:fix,ваш pull request содержит обновления документации,
согласовали их с дизайнерами.
Подробнее о внесении изменений в репозиторий токенов