Closed
Description
i went from 0.4 to 0.7 so maybe i missed something crucial in the upgrade path but somehow my app is not compiling anymore. Example:
node_modules/@graphql-modules/core/node_modules/graphql-toolkit/dist/esnext/utils/validate-documents.d.ts:7:129 - error TS1005: ',' expected.
export declare const validateGraphQlDocuments: (schema: GraphQLSchema, documentFiles: DocumentFile[], effectiveRules?: readonly import("graphql").ValidationRule[]) => readonly LoadDocumentError[];
Activity
dotansimha commentedon Sep 9, 2019
Fixed by @kamilkisiela in ardatan/graphql-toolkit#230
Keeping open until we'll release
graphql-toolkit
and then `graphql-modules.ardatan commentedon Sep 12, 2019
Fixed in 0.7.12 :)
Urigo commentedon Sep 16, 2019
@maapteh why did you reopened the issue?
maapteh commentedon Sep 16, 2019
Ah sorry, i have too many right overhere i think :)
I reopened because the issue still ocurs, less faults but still 2 in 0.7.12:
git clone https://github.com/maapteh/graphql-modules-app.git
yarn
yarn workspace graphql-server buildFIXME
Urigo commentedon Sep 16, 2019
thanks for the context and the reproduction!
ardatan commentedon Sep 17, 2019
@maapteh I reproduced the same error with the old TS version in server's package.json
3.2.1
and when I updated it to3.6.3
, it built successfully.I think it happens because we use a new syntax or something in graphql-toolkit.
maapteh commentedon Sep 17, 2019
Thanks for this update @ardatan i will update. I know TS is optional in modules, but maybe it should become clear you at least need version x?
ardatan commentedon Sep 17, 2019
You're right, we should update documentation about TypeScript version compability :)
6 remaining items