This repository has been archived by the owner on Dec 12, 2022. It is now read-only.
Add the proxy to the local docker compose file #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to start the whole Unleash system (including the proxy) with a single command.
Also: use `UNLEASH_PROXY_CLIENT_KEYS` instead of the deprecated `UNLEASH_PROXY_SECRETS`.
thomasheartman
commented
Apr 5, 2022
Comment on lines
+49
to
50
| # Disable SSL for database connections. @chriswk: why do we do this? | ||
| DATABASE_SSL: "false" |
There was a problem hiding this comment.
@chriswk Do you want to explain to me again what this does and why it's necessary?
There was a problem hiding this comment.
Because otherwise we'd have to configure an SSL certificate for the postgres container, and get the unleash image to trust a custom SSL certificate. Instead we run an unencrypted connection against postgres in this demo setup
thomasheartman
commented
Apr 5, 2022
Comment on lines
+76
to
77
| # trust incoming connections blindly (DON'T DO THIS IN PRODUCTION!) | ||
| POSTGRES_HOST_AUTH_METHOD: "trust" |
There was a problem hiding this comment.
What exactly does this do and why do we need it?
There was a problem hiding this comment.
It allows us to not configure username/passwords for any user. See https://hub.docker.com/_/postgres for further documentation
ivarconr
approved these changes
Apr 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Proxy to the list of services that the docker compose file spins up. This makes it easier for users to start the whole Unleash system.
To achieve this, we start the Unleash server with a default client token.
This PR also adds some explanatory comments to the docker compose file to let the user know what the various environment variables do.