chore: prepare for Yggdrasil with deprecations of changing API #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sighphyre
reviewed
Sep 2, 2024
| @@ -31,6 +31,7 @@ public ToggleBootstrapUrlProvider(string path, HttpClient client, UnleashSetting | |||
| this.customHeaders = customHeaders; | |||
| } | |||
|
|
|||
| [Obsolete("Will return json string in the next major version", false)] | |||
There was a problem hiding this comment.
Think we should do a different method rather than changing the return type
|
What is the replacement for |
There likely won't be a direct replacement. To be completely honest there's still some debate to be had here. The two options (not necessarily competing) are to either return a raw JSON string, which is the unparsed response directly from the server, or a list of names of each of the feature toggles known. IMO exposing the feature toggles directly was never a very good idea, outside of exposing their names. I'm open to suggestions if you're using this in some way we hadn't considered yet though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecations in preparation of Yggdrasil PR that removes some public APIs