feat: automatically generated instanceId #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sighphyre
reviewed
Jul 8, 2024
| } | ||
| }; | ||
| ``` | ||
| The backup file name will follow this pattern: `{fileNameWithoutExtension}-{AppName}-{SdkVersion}.{extension}`. |
There was a problem hiding this comment.
Probably worth mentioning that we took this out and why
There was a problem hiding this comment.
Let me know if this is good enough or if you have a better idea: 00550c7
|
How does this play with this: If I'm reading that right this is still spitting out an error onto the error events. I think it shouldn't do that anymore WDYT? |
sighphyre
approved these changes
Jul 8, 2024
Yep, addressed in 78cf8c2 |
This was referenced Jul 8, 2024
nunogois
added a commit
that referenced
this pull request
Jul 15, 2024
nunogois
added a commit
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-2393/make-instance-id-autogenned-c
This drops the
InstanceTagpublic property inUnleashSettingsin favor of an internal automatically generatedInstanceIdproperty. Any reference ofInstanceTagis nowInstanceId.File names no longer include
InstanceTagand instead we're relying on gracefully handling file locks.