Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yices #46

Merged
merged 13 commits into from
Feb 14, 2023
Merged

Yices #46

merged 13 commits into from
Feb 14, 2023

Conversation

Bupaheh
Copy link
Contributor

@Bupaheh Bupaheh commented Nov 29, 2022

Add Yices converter and internalizer

@Saloed Saloed self-requested a review November 30, 2022 11:31
@Bupaheh Bupaheh requested a review from Saloed December 8, 2022 22:51
@Saloed
Copy link
Collaborator

Saloed commented Dec 9, 2022

Please, fix tests.

@Bupaheh Bupaheh requested a review from Saloed December 20, 2022 00:27
Copy link
Collaborator

@Saloed Saloed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required todos before we can merge:

  1. Windows support
  2. KSolver
  3. Model detach
  4. Tests for model and solver like in Z3BenchmarksBasedTest

@Bupaheh Bupaheh changed the title Yices converter and internalizer Yices Feb 4, 2023
@Bupaheh Bupaheh changed the title Yices Yices Feb 6, 2023
@Bupaheh Bupaheh requested a review from Saloed February 6, 2023 15:29
@Bupaheh Bupaheh requested a review from Saloed February 11, 2023 21:19
Copy link
Collaborator

@Saloed Saloed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase pr before we can merge it.

@Bupaheh Bupaheh requested a review from Saloed February 13, 2023 19:52
@Saloed Saloed merged commit e681a2a into UnitTestBot:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants