Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #88

Merged
merged 2 commits into from
Nov 5, 2021
Merged

Update README.md #88

merged 2 commits into from
Nov 5, 2021

Conversation

MenacingPerson
Copy link

No description provided.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@MenacingPerson
Copy link
Author

Huh. There is a PR https://github.com/MultiMC/Launcher/pull 4221 on MultiMC's main repo about exactly this.

I doubt it'll be merged as it does not follow the normal contributing rules and also has bad english. Also removes the crowdin link.

@max8rr8 max8rr8 merged commit e5245ba into UltimMC:develop Nov 5, 2021
@MenacingPerson MenacingPerson deleted the patch-1 branch November 5, 2021 12:08
@polymo1
Copy link

polymo1 commented Nov 9, 2021

Huh. There is a PR https://github.com/MultiMC/Launcher/pull 4221 on MultiMC's main repo about exactly this.

I doubt it'll be merged as it does not follow the normal contributing rules and also has bad english. Also removes the crowdin link.

I beg your pardon. I only deleted text, not added. And the only other changes were changing "MultiMC" to "Launcher"

@MenacingPerson
Copy link
Author

We keep Launcher open source because

for example. This would be better as

We keep the launcher open source because

and

If you want to build Launcher yourself, check

would be better as

If you want to build the launcher yourself, check

Also you removed the crowdin link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants