Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mumble] fix broken guide #1456

Merged
merged 5 commits into from
Jan 3, 2023
Merged

[mumble] fix broken guide #1456

merged 5 commits into from
Jan 3, 2023

Conversation

franok
Copy link
Contributor

@franok franok commented Dec 14, 2022 •
edited
Loading

update guide, for details see: #1191 (comment)

closes #1191

@franok franok changed the title mumble: fix broken guide [mumble] fix broken guide Dec 14, 2022
@kimdiallo kimdiallo self-assigned this Jan 3, 2023
kimdiallo
kimdiallo requested changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@kimdiallo kimdiallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your effort - but a few small changes are still needed.

source/guide_mumble.rst Show resolved Hide resolved
source/guide_mumble.rst Outdated Show resolved Hide resolved
source/guide_mumble.rst Show resolved Hide resolved
franok
franok commented Jan 3, 2023
View reviewed changes
source/guide_mumble.rst Outdated Show resolved Hide resolved
@franok
Copy link
Contributor Author

franok commented Jan 3, 2023

@kimdiallo thank you for the review, I addressed the requested changes, see my commits/comments

@kimdiallo kimdiallo merged commit 9ce82b4 into Uberspace:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimdiallo kimdiallo kimdiallo requested changes

Assignees

@kimdiallo kimdiallo

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@franok @kimdiallo @SalocinHB