[Nextcloud] make install command parameters bulletproof #1332
Conversation
EV21
changed the title
EV21
force-pushed
the
nextcloud
branch
2 times, most recently
from
30df924 to
954355c
Compare
| @@ -249,7 +249,7 @@ Add the following cronjob to your :manual:`crontab <daemons-cron>`: | |||
|
|
|||
| :: | |||
|
|
|||
| */5 * * * * sleep $(( 1 + $RANDOM \% 60 )) ; php -f $HOME/html/cron.php > $HOME/logs/nextcloud-cron.log 2>&1 | |||
| */5 * * * * sleep $(( 1 + RANDOM % 60 )) ; php -f $HOME/html/cron.php > $HOME/logs/nextcloud-cron.log 2>&1 | |||
There was a problem hiding this comment.
The % needs to be escaped. From crontab's man page:
The "sixth" field (the rest of the line) specifies the command to be run. The entire command portion of the line, up to a new‐line or a "%" character, will be executed by /bin/sh or by the shell specified in the SHELL variable of the cronfile. A "%" character in the command, unless escaped with a backslash (), will be changed into newline characters, and all data after the first % will be sent to the command as standard input.
There was a problem hiding this comment.
#1479 That PR also adds a note as this is absolutely uncommon. This feature is actually a bug (in my opinion). They (the crontab devs) should not mess with the syntax in this way, instead crontab should use its own replacement code for such things.
In my test run my credentials are
The
--database-pass[=DATABASE-PASS]has an optional argument (not like the other ones) and in my case the password starts with-M,so the Symfony CLI logic sees this thing as flagwith
=it worksSince the official documentation also uses the space separation it looks like a bug.
https://docs.nextcloud.com/server/latest/admin_manual/installation/command_line_installation.html
Maybe just let us use the bulletproof connected variant to avoid these cases when the password generator likes to have a
-at the beginning 🤣 (It is not the first time I got a password like that, I also got it once on U5/U6 too)deploy preview 👀