Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tomcat] add guide for tomcat #1182

Merged
merged 7 commits into from
Jan 27, 2022
Merged

[tomcat] add guide for tomcat #1182

merged 7 commits into from
Jan 27, 2022

Conversation

cmacht
Copy link
Contributor

@cmacht cmacht commented Jan 9, 2022 •
edited
Loading

Added a guide for Java Tomcat and fixed the spelling of my user url in another guide.

@noave noave self-assigned this Jan 27, 2022
noave
noave requested changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@noave noave left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much, I added some minor change comments, but it works and will be happy to merge after they have been resolved :)

source/guide_tomcat.rst Outdated Show resolved Hide resolved
source/guide_tomcat.rst Outdated Show resolved Hide resolved
source/guide_tomcat.rst Show resolved Hide resolved
source/guide_tomcat.rst Outdated Show resolved Hide resolved
source/guide_tomcat.rst Outdated Show resolved Hide resolved
source/guide_tomcat.rst Outdated Show resolved Hide resolved
source/guide_tomcat.rst Outdated Show resolved Hide resolved
noave
noave requested changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@noave noave left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...

@cmacht cmacht requested a review from noave January 27, 2022 14:20
@cmacht
Copy link
Contributor Author

cmacht commented Jan 27, 2022

Thanks for the thorough review! I fixed your findings and as a little bonus, added the .. code-block:: console context to the flask guide as well.

@noave
Copy link
Contributor

noave commented Jan 27, 2022

thanks!

@noave noave merged commit 311215e into Uberspace:main Jan 27, 2022
@noave
Copy link
Contributor

noave commented Jan 27, 2022 •
edited
Loading

please ping us at hallo@uberspace.de for a new cup if you like 🎉 ☕

@cmacht cmacht deleted the guide-tomcat branch October 14, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noave noave noave approved these changes

Assignees

@noave noave

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmacht @noave