Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The python 'aifc' library is removed in python 3.13.0 #775

Closed
aaronmader opened this issue Oct 25, 2024 · 4 comments
Closed

The python 'aifc' library is removed in python 3.13.0 #775

aaronmader opened this issue Oct 25, 2024 · 4 comments
Assignees
@ftnext

Comments

@aaronmader
Copy link

The speech_recognition library is unable to run on python 3.13.0, because of the removal of standard libraries like aifc (and possibly others)

We probably just need to specify a new dependency, possibly https://pypi.org/project/standard-aifc/ ?
Note: I haven't done my due-diligence evaluating this library or its maintainer.
@ftnext
Copy link
Collaborator

ftnext commented Oct 26, 2024

As written in the metadata, the current SpeechRecognition (3.11.0) supports Python 3.9 through 3.12.
We welcome information of migration where aifc is moving to add support for 3.13 in the future.
standard-aifc might be one of the candidates (verification needed), thanks!

links

@cdce8p cdce8p mentioned this issue Oct 30, 2024
Merged
44 tasks
@ftnext
Copy link
Collaborator

ftnext commented Nov 3, 2024

pytest mentions 'audioop' removal as well as 'aifc'.
https://github.com/Uberi/speech_recognition/actions/runs/11643697199/job/32424738545

=============================== warnings summary ===============================
speech_recognition/__init__.py:7
  /home/runner/work/speech_recognition/speech_recognition/speech_recognition/__init__.py:7: DeprecationWarning: 'aifc' is deprecated and slated for removal in Python 3.13
    import aifc

speech_recognition/__init__.py:8
  /home/runner/work/speech_recognition/speech_recognition/speech_recognition/__init__.py:8: DeprecationWarning: 'audioop' is deprecated and slated for removal in Python 3.13
    import audioop

@ftnext ftnext mentioned this issue Nov 3, 2024
Merged
@ftnext
Copy link
Collaborator

ftnext commented Nov 3, 2024

Added in setup.py

speech_recognition/setup.py

Lines 73 to 77 in 46bb470

install_requires=[
"typing-extensions",
"standard-aifc; python_version>='3.13'",
"audioop-lts; python_version>='3.13'",
],

TODO: Run tests on Python 3.13 (but PyTorch (openai-whisper depends) doesn't support 3.13 yet, so we need to skip some tests)

@ftnext ftnext removed the help wanted label Nov 3, 2024
@ftnext ftnext self-assigned this Nov 3, 2024
@ftnext ftnext mentioned this issue Nov 3, 2024
Merged
@ftnext
Copy link
Collaborator

ftnext commented Nov 3, 2024 

% python -V
Python 3.13.0

% python -m pip install standard-aifc setuptools
% python -m pip install --no-build-isolation git+https://github.com/Uberi/speech_recognition

@ftnext ftnext closed this as completed Nov 3, 2024
@cclauss cclauss mentioned this issue Nov 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ftnext ftnext

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaronmader @ftnext