Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct uses of project_name in pyproject.toml #309

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Correct uses of project_name in pyproject.toml #309

merged 1 commit into from
Feb 19, 2024

Conversation

dstansby
Copy link
Member

  1. Fix [tool.coverage] so coverage data is collected correctly. I haven't come up with a way to test this, other than this is the fix I needed at https://github.com/hipCTProject/hipct-reg
  2. While I was at it, I noticed a second place where custom logic could just be repalced with project_name

paddyroddy
paddyroddy approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot

@dstansby dstansby merged commit ee81654 into main Feb 19, 2024
15 checks passed
@dstansby dstansby deleted the fix-package-name branch February 19, 2024 15:40
dstansby added a commit that referenced this pull request Mar 23, 2024
@dstansby
Revert "Correct uses of project_name in pyproject.toml (#309)"
14dc31e 
This reverts commit ee81654.
This was referenced Mar 23, 2024
Merged
Closed
@dstansby dstansby mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paddyroddy paddyroddy paddyroddy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstansby @paddyroddy