Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TT-1683 added config for purge analytics interval #3526

Merged
merged 5 commits into from
Apr 13, 2021
Merged

TT-1683 added config for purge analytics interval #3526

merged 5 commits into from
Apr 13, 2021

Conversation

sredxny
Copy link
Contributor

@sredxny sredxny commented Apr 9, 2021 •
edited
Loading

Description

Added a config to set the interval length (in seconds) on how often we should purge the analytics from the rpc cache.

Related Issue

https://tyktech.atlassian.net/browse/TT-1683

Motivation and Context

Give solution to https://tyktech.atlassian.net/browse/TT-1683

How This Has Been Tested

  • Set config to 5
  • Set analytics type "rpc"
  • Ran GW
  • perform some requests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own
    fork, don't request your master!
  • Make sure you are making a pull request against the master branch (left side). Also, you should start
    your branch off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
    • If new config option added, ensure that it can be set via ENV variable
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • When updating library version must provide reason/explanation for this update.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • go fmt -s
    • go vet

@sredxny sredxny mentioned this pull request Apr 9, 2021
Merged
@sredxny
Copy link
Contributor Author

sredxny commented Apr 9, 2021

Docuemntation added in TykTechnologies/tyk-docs#1622

@sredxny
Copy link
Contributor Author

sredxny commented Apr 9, 2021

Failing test is not related to this change

matiasinsaurralde
matiasinsaurralde approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@matiasinsaurralde matiasinsaurralde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tbuchaillot
tbuchaillot approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@tbuchaillot tbuchaillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregdelhon gregdelhon merged commit 4235775 into master Apr 13, 2021
@gregdelhon gregdelhon deleted the TT-1683-add-analytics-job-interval-as-config branch April 13, 2021 14:13
@tbuchaillot
Copy link
Contributor

/release to release-3

@tykbot
Copy link

tykbot bot commented Apr 13, 2021

Working on it! Note that it can take a few minutes.

@tykbot
Copy link

tykbot bot commented Apr 13, 2021

@tbuchaillot Seems like there is conflict and it require manual merge.

@tbuchaillot
Copy link
Contributor

/release to release-3-lts

@tykbot
Copy link

tykbot bot commented Apr 13, 2021

Working on it! Note that it can take a few minutes.

tykbot bot pushed a commit that referenced this pull request Apr 13, 2021
@sredxny
TT-1683 added config for purge analytics interval (#3526)
fc79fb6 
* TT-1683 added config for purge analytics interval

* ra goimports on rpc_analytics_purger.go

* added purge_interval to lintern schema

Co-authored-by: Tomas Buchaillot <tombuchaillot89@gmail.com>
(cherry picked from commit 4235775)
@tykbot
Copy link

tykbot bot commented Apr 13, 2021

@tbuchaillot Succesfully merged 423577535aea2f720677da62891f010b7bf75f7a to release-3-lts branch.

@tbuchaillot
Copy link
Contributor

/release to release-3

@tykbot
Copy link

tykbot bot commented Apr 13, 2021

Working on it! Note that it can take a few minutes.

tykbot bot pushed a commit that referenced this pull request Apr 13, 2021
@sredxny
TT-1683 added config for purge analytics interval (#3526)
b0eced2 
* TT-1683 added config for purge analytics interval

* ra goimports on rpc_analytics_purger.go

* added purge_interval to lintern schema

Co-authored-by: Tomas Buchaillot <tombuchaillot89@gmail.com>
(cherry picked from commit 4235775)
@tykbot
Copy link

tykbot bot commented Apr 13, 2021

@tbuchaillot Succesfully merged 423577535aea2f720677da62891f010b7bf75f7a to release-3 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiasinsaurralde matiasinsaurralde matiasinsaurralde approved these changes

@tbuchaillot tbuchaillot tbuchaillot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sredxny @tbuchaillot @matiasinsaurralde @gregdelhon